Scissors - Araceli #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbieniosek
reviewed
Jun 29, 2021
| // } | ||
| // }, [result]); | ||
|
|
||
| const changePlayers = () => { |
| changePlayers(); | ||
| checkForWinner(); | ||
|
|
||
| }; | ||
|
|
||
|
|
||
| const checkForWinner = () => { |
There was a problem hiding this comment.
All of the logic in here works! With some minor changes it can be updated to update the UI (and pass the tests):
- set a variable (ex: let winner = null) at the top of the function.
- If a winner is ever found, set winner equal to the player that has won (ex, on line 78 winner = squares[0][index].value).
- At the end of the function save the winner in state.
- Create a function that checks the winner state variable and returns a string that contains either "Winner is [winner]" or "The winner is..." and call the function on line 123 inside the tags.
The last piece is to add a check at the top of markSquares that returns if a winner has been found so that squares can not continue to be marked.
| // possibly try to use a counter? | ||
|
|
||
| }; | ||
|
|
||
|
|
||
| const resetGame = () => { |
Comment on lines
+75
to
+79
| if (squares[0][index].value===squares[1][index].value && | ||
| squares[1][index].value===squares[2][index].value && | ||
| squares[0][index].value!=='') { | ||
| alert(`Game Finished! Winning Player: ${player}`); | ||
| resetGame(); |
There was a problem hiding this comment.
This chunk of code is repeated for rows and diagonals, the only changes are which points are being checked. I recommend thinking about creating a helper function that does this comparison function to improve readability.
|
Great work on this project! All of the logic for checking for a win works very well. Nice work with the reset extension! This project is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.